Code smells detection via modern code review: a study of the OpenStack and Qt communities

Code review plays an important role in software quality control. A typical process involves a careful check of piece code attempt to detect and locate defects other issues/violations. One type issue that may impact the is smells - i.e., bad coding practices lead or maintenance issues. Yet, little known about extent which are identified during modern review. To investigate concept behind what actions reviewers suggest developers take response smells, we conducted empirical study reviews by analysing from four, large open source projects OpenStack (Nova Neutron) Qt (Qt Base Creator) communities. We manually checked total 25,415 comments obtained keywords search random selection; this resulted identification 1,539 smell-related then allowed causes taken against time fix reasons why ignored fixing smells. Our analysis found 1) were not commonly reviews, 2) usually caused violation conventions, 3) provided constructive feedback, including (refactoring) recommendations help remove 4) generally followed those actioned changes, 5) once reviewers, it takes less than one week 6) main reason chose ignore worth smell. results following: should closely follow conventions their avoid introducing review-based detection perceived be trustworthy approach developers, mainly because context-sensitive (as more aware context given they part project’s development team) program needs fully considered order make decision whether smell immediately.